Make tests os independent #210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nward
force-pushed
the
remove_redhat_params_class
branch
from
ef7a4a4
to
1403a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all tests os-independent, and removes RedHat tests contexts which forced all OSes to behave as though they were RedHat during testing.
The general structure I have followed, is to put a case/when/end block at the top of each context, do any os-specific test there, and then have os-independent tests after that block.
Examples of os-dependent things are usernames, group names, paths, and packages.
In the case of the tests for the
freeradiusclass, this is quite a large block and takes up the first 1/3 of the file, but for the other tests it is clearer.Note that this will fail tests until #209 is merged and this is rebased, so I am leaving this draft until then.